Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: storage endpoint config #43

Merged
merged 6 commits into from
Jul 5, 2022

Conversation

karitra
Copy link
Contributor

@karitra karitra commented May 11, 2022

Enables additional options to make it possible to specify custom post-processing storage endpoint and region or allow storage endpoint to be discovered via YC API.

Closes #42

@karitra karitra requested a review from a team as a code owner May 11, 2022 15:50
@hashicorp-cla
Copy link

hashicorp-cla commented May 11, 2022

CLA assistant check
All committers have signed the CLA.

@karitra karitra closed this May 11, 2022
@karitra karitra deleted the feat/storage-endpoint-config branch May 11, 2022 15:58
@karitra karitra restored the feat/storage-endpoint-config branch May 11, 2022 16:09
@karitra karitra reopened this May 11, 2022
@karitra karitra changed the title Feat/storage endpoint config Feat: storage endpoint config May 12, 2022
Copy link
Contributor

@Direnol Direnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Direnol
Copy link
Contributor

Direnol commented May 17, 2022

Hi @azr @nywilken !
Please review this PR.

@nywilken
Copy link
Contributor

nywilken commented Jul 1, 2022

Hi there, I need to look into why the checks did not run. But this change requires that you run make generate to update the documentation and hclspec files for the newly added fields. Can you please run make generate or go generate ./... and commit the generated files.

@nywilken
Copy link
Contributor

nywilken commented Jul 1, 2022

@GennadySpb these changes look good to me. Could I get your eyes on it as well. @Direnol thanks for the review. I've pinged the codeowner for review as well.

@karitra
Copy link
Contributor Author

karitra commented Jul 4, 2022

@nywilken, make generate done, PTAL.
#43 (comment)

@GennadySpb
Copy link
Contributor

@nywilken LGTM

btw, @Direnol also the same codeowner as me. I'll add him to the CODEOWNERS file.

@nywilken nywilken merged commit be7f276 into hashicorp:main Jul 5, 2022
@nywilken
Copy link
Contributor

nywilken commented Jul 5, 2022

@nywilken LGTM

btw, @Direnol also the same codeowner as me. I'll add him to the CODEOWNERS file.

Got it, thanks for that info and the CODEOWNERS PR. @Direnol apologies for not flagging you as a codeowner.

@nywilken
Copy link
Contributor

nywilken commented Jul 5, 2022

Thanks for the update @karitra, apologies for the longer than normal review time. The feature has been released in v1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make object storage and region configurable
5 participants