Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl use of content of the service account key file in the environment variable YC_SERVICE_ACCOUNT_KEY_FILE #82

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

GennadySpb
Copy link
Contributor

Closes #39

@GennadySpb GennadySpb requested a review from a team as a code owner August 10, 2023 17:12
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GennadySpb,

I just left a quick suggestion to correct a typo, other than that, the code looks good to me.

If possible, could you rebase this on top of the current main and run make build-docs?
Since we moved from the old documentation system to the new, the documentation gets compiled in a different directory, and is being checked through an action, which is on main, but not on your branch since the PR was opened before this was made.
Otherwise since there's a couple of open PRs already is we can merge this one when you've fixed the typo, and we'll fix the docs before release, this implies main will be red for a while.

Thanks for taking care of this!

type keyType int

const (
Undefinded keyType = iota
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here

Suggested change
Undefinded keyType = iota
Undefined keyType = iota

@nywilken nywilken force-pushed the feature/sa-key-file branch from 05e857a to 16d8311 Compare October 27, 2023 14:52
@nywilken
Copy link
Contributor

@lbajolet-hashicorp I went ahead and pushed up the suggested changes and generated the missing docs. I will merge once this goes green.

@nywilken nywilken merged commit b5cc132 into hashicorp:main Oct 27, 2023
11 checks passed
@GennadySpb GennadySpb deleted the feature/sa-key-file branch October 28, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use of content of the service account key file in the environment variable YC_SERVICE_ACCOUNT_KEY_FILE
3 participants