Implement hcp_packer_registry block #11168

sylviamoss · 2021-07-27T10:15:07Z

Write tests
Add docs

Testing template

source "file" "basic-example" {
  content = "Lorem ipsum dolor sit amet"
  target = "dummy_artifact"
}

source "file" "basic-example-2" {
  content = "Lorem ipsum dolor sit amet"
}


build {
  hcp_packer_registry {
    description = <<EOT
Base Alpine container used across fakeorg to ensure the most
secure computing environment for team applications. The use of any other image is highly discouraged :DDDD.
    EOT

    labels = {
      "go" = "1.16.3",
      "ruby" = "3.0.1",
      "kernel" = "3.4.0",
      "fake" = "labels"
    }
  }

  name = "mosses-simple-artifact"
  sources = ["sources.file.basic-example"]

  source "source.file.basic-example-2" {
    target = "dummy_artifact_two"
  }
}

nywilken

This looks really good. I left a couple of questions.

hcl2template/types.build.go

internal/packer_registry/client.go

internal/packer_registry/env/env.go

nywilken

This looks great! I left a few nits and one question. But this is otherwise good to go. Nicely done. Feel free to merge when ready.

nywilken · 2021-07-28T13:45:01Z

hcl2template/testdata/hcp_par/complete.pkr.hcl

+        "source.virtualbox-iso.ubuntu-1204",
+    ]
+
+    source "source.amazon-ebs.ubuntu-1604" {


Nice touch. Great to see this being captured in the test 🐛 👮

hcl2template/testdata/hcp_par/duplicate.pkr.hcl

hcl2template/common_test.go

nywilken · 2021-07-28T13:53:56Z

hcl2template/types.build.hcp_packer_registry.go

+}
+
+func (b *HCPPackerRegistryBlock) WriteBucketConfig(bucket *packerregistry.Bucket) {
+	if b == nil {


Now that I learned this was possible 😆

hcl2template/types.build.hcp_packer_registry.go

website/content/docs/templates/hcl_templates/blocks/build/hcp_packer_registry.mdx

azr

Heya, nice going ! I just had a few comments/concerns there and there, but I like the direction.

command/core_wrapper.go

azr · 2021-07-28T14:26:33Z

hcl2template/testdata/hcp_par/complete.pkr.hcl

+    name = "bucket-slug"
+
+    hcp_packer_registry {
+        description = <<EOT
+Some description
+    EOT
+        labels = {
+            "foo" = "bar"
+        }
+    }


I think that the bucket setting should be specific and not be taken from the build block, this could get quite confusing ! Like what if I want to name my build with something but push to another bucket ?

Suggested change

name = "bucket-slug"

hcp_packer_registry {

description = <<EOT

Some description

EOT

labels = {

"foo" = "bar"

}

}

name = "build-name"

hcp_packer_registry {

push_to = "alpine"

description = <<EOT

Some description

EOT

labels = {

"foo" = "bar"

}

}

Another question on the same topic, why not taking the description from the build and put that in the bucket too ?

I think that the bucket setting should be specific and not be taken from the build block, this could get quite confusing ! Like what if I want to name my build with something but push to another bucket ?

This is fair. From the minimal viable configuration option stand point " A user should be able to push to PAR simply by adding a few environment variables" so this keeps to this promise as long as a build name is part of the configuration template. Or the user provides a HCP_PACKER_BUILD_NAME env variable along side the HCP creds.

That said I think that supporting a different build name in the future (it would be great to get beta feedback here) can be a simple thing to do. But for now it feels a little out of scope. Of course happy to be told differently.

Nice! I will make the same logic for both slug and description. If not present in hcp_packer_registry, then use the ones from build.

Also, the description is not documented in the deployed docs. Is it missing or is it something new?

(talking to Wilken) I'd think the opposite, I think it would be quite easier to make of that a variable, and then pass it to the build and hcp blocks, to not repeat myself.

pinging @SwampDragons as well for thoughts on last question.

Adding a note here that I initially expected component type to be just the component that built that thing; so the docker builder, the amazon-ebs builder or the google-import pp; for example.

To me, this is marketing, not a technical spec 😛

This is a technical spec. Otherwise it's not marketing, it's a lie.

When writing the service, I imagined "component-type" as literally the builder or post-processor that created the builder, without either name

Ah, yes, what Adrien said.

hcl2template/types.build.go

hcl2template/types.build.hcp_packer_registry.go

…packer_registry.mdx Co-authored-by: Wilken Rivera <wilken@hashicorp.com>

* parse hcp_packer_registry block * Add config to hcp_packer_registry block * get org and proj id from client secrets * move org and proj id logic to client * clean up client config * rename InPARMode to HasHCPCredentials * add HCP_PACKER_REGISTRY back to enable PAR when hcp block not present * validate credentials when creating client * fix - allow hcl2 config par enable without block * fix build registration * update error msg * fix IsPAREnabled logic * fix par enabled and bucket validation * update hcp-sdk-go * add hcp_packer_registry tests * add some doc in the code * add packer.io docs * Update website/content/docs/templates/hcl_templates/blocks/build/hcp_packer_registry.mdx Co-authored-by: Wilken Rivera <wilken@hashicorp.com> * remove copy and paste * add slug option to hcp_packer_registry * add slug docs Co-authored-by: Wilken Rivera <wilken@hashicorp.com>

* Add working registry pkg * Add custom error for handling the loading of PAR environment variables * Working Publish to Build, with proper error handling for bucket names * Update hcp-sdk-go to use branch instead of mod replace directive * Update Packer build status configuration * Add support for HCP_PACKER_BUILD_FINGERPRINT env * Add support for publishing one or more PARtifacts from a single build * add git shas to this branch * Add ability to set provider name if available * Add working RegistryBuilder type * Add RegistryPostProcessor as wrapper post-processor * When in PAR mode a empty RegistryPostProcessor is added to the end of the post-processor list to publish all final image data. * Add support for updating a build from PAR that is not in a DONE state * Fix a small issue with creation the initial builds for an empty iteration. * Add PAR URL to post-processor display * Implement hcp_packer_registry block (#11168) * Update vendored Amazon plugin to v1.0.1-dev * Fix panic when running a Packer registry build in a clean directory * Remove the publishing of post-processor metadata from the registry post-processor. * Remove metadata add from registry_builder * Update registry builder to skip a build that was found to be DONE Co-authored-by: Megan Marsh <megan@hashicorp.com> Co-authored-by: Sylvia Moss <moss@hashicorp.com>

github-actions · 2021-08-28T02:02:29Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

sylviamoss changed the base branch from master to embed-corebuild-publisher July 27, 2021 10:15

parse hcp_packer_registry block

2ed61f8

sylviamoss force-pushed the hcp_registry_block branch from b123a53 to 2ed61f8 Compare July 27, 2021 10:25

vercel bot temporarily deployed to Preview July 27, 2021 10:25 Inactive

Add config to hcp_packer_registry block

765715f

vercel bot temporarily deployed to Preview July 27, 2021 12:38 Inactive

vercel bot temporarily deployed to Preview July 27, 2021 13:06 Inactive

get org and proj id from client secrets

9943301

sylviamoss force-pushed the hcp_registry_block branch from f004e68 to 9943301 Compare July 27, 2021 13:19

vercel bot temporarily deployed to Preview July 27, 2021 13:19 Inactive

move org and proj id logic to client

92ff0c0

vercel bot temporarily deployed to Preview July 27, 2021 13:23 Inactive

clean up client config

9bcd11f

vercel bot temporarily deployed to Preview July 27, 2021 13:32 Inactive

rename InPARMode to HasHCPCredentials

da7b756

vercel bot temporarily deployed to Preview July 27, 2021 13:40 Inactive

add HCP_PACKER_REGISTRY back to enable PAR when hcp block not present

b603f98

vercel bot temporarily deployed to Preview July 27, 2021 14:33 Inactive

validate credentials when creating client

7e8756e

sylviamoss force-pushed the hcp_registry_block branch from 574e3d0 to 7e8756e Compare July 27, 2021 14:34

vercel bot temporarily deployed to Preview July 27, 2021 14:34 Inactive

fix - allow hcl2 config par enable without block

3cc3a73

vercel bot temporarily deployed to Preview July 27, 2021 14:42 Inactive

vercel bot temporarily deployed to Preview July 27, 2021 15:03 Inactive

fix build registration

31f9410

sylviamoss force-pushed the hcp_registry_block branch from 8dcb04e to 31f9410 Compare July 27, 2021 15:09

vercel bot temporarily deployed to Preview July 27, 2021 15:09 Inactive

update error msg

9408f91

vercel bot temporarily deployed to Preview July 27, 2021 15:23 Inactive

nywilken reviewed Jul 27, 2021

View reviewed changes

hcl2template/types.build.go Show resolved Hide resolved

internal/packer_registry/client.go Show resolved Hide resolved

internal/packer_registry/env/env.go Outdated Show resolved Hide resolved

add hcp_packer_registry tests

44a0393

sylviamoss force-pushed the hcp_registry_block branch from 4d55796 to 44a0393 Compare July 28, 2021 12:40

vercel bot temporarily deployed to Preview July 28, 2021 12:40 Inactive

add some doc in the code

83fbd8e

vercel bot temporarily deployed to Preview July 28, 2021 12:55 Inactive

vercel bot deployed to Preview July 28, 2021 13:10 View deployment

sylviamoss force-pushed the hcp_registry_block branch from c5090d7 to 5fc3802 Compare July 28, 2021 13:25

vercel bot deployed to Preview July 28, 2021 13:26 View deployment

add packer.io docs

81dad99

sylviamoss force-pushed the hcp_registry_block branch from 5fc3802 to 81dad99 Compare July 28, 2021 13:33

vercel bot deployed to Preview July 28, 2021 13:33 View deployment

sylviamoss marked this pull request as ready for review July 28, 2021 13:33

sylviamoss requested a review from a team as a code owner July 28, 2021 13:33

nywilken approved these changes Jul 28, 2021

View reviewed changes

azr reviewed Jul 28, 2021

View reviewed changes

Update website/content/docs/templates/hcl_templates/blocks/build/hcp_…

7a521fb

…packer_registry.mdx Co-authored-by: Wilken Rivera <wilken@hashicorp.com>

vercel bot deployed to Preview July 28, 2021 14:49 View deployment

sylviamoss added 2 commits July 28, 2021 17:26

remove copy and paste

c8975e8

add slug option to hcp_packer_registry

a953b65

vercel bot temporarily deployed to Preview July 28, 2021 15:26 Inactive

add slug docs

2bd88c1

vercel bot deployed to Preview July 28, 2021 15:31 View deployment

sylviamoss merged commit 26e39b5 into embed-corebuild-publisher Jul 28, 2021

sylviamoss deleted the hcp_registry_block branch July 28, 2021 16:15

github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement hcp_packer_registry block #11168

Implement hcp_packer_registry block #11168

sylviamoss commented Jul 27, 2021 •

edited

Loading

nywilken left a comment

nywilken left a comment

nywilken Jul 28, 2021

nywilken Jul 28, 2021

sylviamoss Jul 28, 2021

azr left a comment

azr Jul 28, 2021 •

edited

Loading

azr Jul 28, 2021

nywilken Jul 28, 2021 •

edited

Loading

sylviamoss Jul 28, 2021

azr Jul 28, 2021 •

edited

Loading

nywilken Jul 28, 2021

azr Jul 28, 2021 •

edited

Loading

SwampDragons Jul 28, 2021

SwampDragons Jul 28, 2021

SwampDragons Jul 28, 2021

github-actions bot commented Aug 28, 2021

Implement hcp_packer_registry block #11168

Implement hcp_packer_registry block #11168

Conversation

sylviamoss commented Jul 27, 2021 • edited Loading

nywilken left a comment

Choose a reason for hiding this comment

nywilken left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azr left a comment

Choose a reason for hiding this comment

azr Jul 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nywilken Jul 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azr Jul 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azr Jul 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 28, 2021

sylviamoss commented Jul 27, 2021 •

edited

Loading

azr Jul 28, 2021 •

edited

Loading

nywilken Jul 28, 2021 •

edited

Loading

azr Jul 28, 2021 •

edited

Loading

azr Jul 28, 2021 •

edited

Loading