Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packer plugins command and subcommands to interact with plugins #11553

Merged
merged 32 commits into from
Feb 10, 2022

Conversation

azr
Copy link
Contributor

@azr azr commented Feb 7, 2022

❯ packer plugins -h
Usage: packer plugins <subcommand> [options] [args]
  This command groups subcommands for interacting with Packer plugins.

Related but not under the "plugins" command :

- "packer init <path>" will install all plugins required by a config.

Subcommands:
    install      Install latest Packer plugin [matching version constraint]
    installed    List all installed Packer plugins binaries
    remove       Remove Packer plugins [matching a version]
    required     List plugins required by a config
  • feature
  • docs
  • tests

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review looks really good. Nicely done. I left a few suggestion, and will continue with the testing code later today.

command/plugins_installed.go Outdated Show resolved Hide resolved
command/plugins_remove.go Show resolved Hide resolved
command/plugins_required.go Show resolved Hide resolved
command/plugins_required.go Outdated Show resolved Hide resolved
Co-Authored-By: Wilken Rivera <1749304+nywilken@users.noreply.github.com>
Co-Authored-By: Wilken Rivera <1749304+nywilken@users.noreply.github.com>
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good so far. I left a few more suggestions to fix a few small typos but this is otherwise good.

website/content/docs/commands/plugins/install.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/plugins/remove.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/plugins/required.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/plugins/required.mdx Outdated Show resolved Hide resolved
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
Copy link

@ChiefGhostZero0x1 ChiefGhostZero0x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix config setup to include other packers

Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
@azr azr marked this pull request as ready for review February 9, 2022 16:17
@azr azr requested a review from a team as a code owner February 9, 2022 16:17
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Awesome 🚀

@nywilken nywilken merged commit 9f4a128 into master Feb 10, 2022
@nywilken nywilken deleted the azr/packer-plugins-command branch February 10, 2022 21:55
@azr
Copy link
Contributor Author

azr commented Feb 11, 2022

Thanks !!!!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants