-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packer plugins
command and subcommands to interact with plugins
#11553
Conversation
azr
commented
Feb 7, 2022
•
edited
Loading
edited
- feature
- docs
- tests
Co-Authored-By: Wilken Rivera <1749304+nywilken@users.noreply.github.com>
they do nothing for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review looks really good. Nicely done. I left a few suggestion, and will continue with the testing code later today.
Co-Authored-By: Wilken Rivera <1749304+nywilken@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good so far. I left a few more suggestions to fix a few small typos but this is otherwise good.
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix config setup to include other packers
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Awesome 🚀
Thanks !!!! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |