-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all shells: Pass env vars through a key value store #11569
Conversation
] | ||
} | ||
provisioner "shell-local" { | ||
only_on = ["windows"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a neat feature for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice little gem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I do wonder if we should deprecate the environment_vars
field.
…902d6d1bd7d907d2 + tidy
Good question, I would think not here, since for the people using On another side: these work with datasources, so it's way better 🤔 . |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This potentially fixes #11197, by allowing to set shell env vars from a key/value map.
Merge hashicorp/packer-plugin-sdk#98 first.
key
/value
store possibility