Associate Packer build to HCP Packer parent iteration #11832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
changed the title
added 2 commits
June 6, 2022 21:09
* Fix typo for HCP_PACKER_BUILD_FINGERPRINT env in test * Add test Fingerprint where needed; failing tests were not showing because they are properly set for acctest
nywilken
force-pushed
the
nywilken/parent-iteration-id
branch
from
c75d489 to
a49efc5
Compare
nywilken
changed the title
sylviamoss
reviewed
Jun 10, 2022
| @@ -48,7 +48,8 @@ func (p *Parser) decodeHCPRegistry(block *hcl.Block, cfg *PackerConfig) (*HCPPac | |||
| BuildLabels map[string]string `hcl:"build_labels,optional"` | |||
| Config hcl.Body `hcl:",remain"` | |||
| } | |||
| diags := gohcl.DecodeBody(body, cfg.EvalContext(LocalContext, nil), &b) | |||
| ectx := cfg.EvalContext(DatasourceContext, nil) | |||
There was a problem hiding this comment.
I think it makes more sense if this is BuildContext considering that the hcp_packer_registry is inside the build block. What do you think?
There was a problem hiding this comment.
Good point. I'll update.
sylviamoss
approved these changes
Jun 10, 2022
|
I tested it by creating child iterations based on one and two parents. All worked as expected, so 👍🏼 !! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows Packer core to validate that a newly build image is a child of a HCP Packer registry source image. This association is handle by checking the source of a build against the reported source image of a build artifact that is configured to publish to the HCP Packer registry.