Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packages for iso builds #12081

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Add packages for iso builds #12081

merged 1 commit into from
Oct 28, 2022

Conversation

paulojmdias
Copy link
Contributor

Add support to build images using packer that needs to create ISO files.

Closes #11908

@paulojmdias paulojmdias requested a review from a team as a code owner October 25, 2022 22:09
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lbajolet-hashicorp
lbajolet-hashicorp approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@paulojmdias
Copy link
Contributor Author

paulojmdias commented Oct 28, 2022 •
edited
Loading

LGTM, thanks for the fix!

Thank you @lbajolet-hashicorp!

Could you merge it, please?

@nywilken nywilken added this to the 1.8.5 milestone Oct 28, 2022
@lbajolet-hashicorp
Copy link
Contributor

Hi @paulojmdias,

I'll merge this when we're done with the current release cycle, scheduled for today. I understand this will probably not jeopardize the process, but at the same time I prefer being cautious for now.

The release will happen today, your PR will be merged subsequently, either today or by Monday.

@lbajolet-hashicorp
Copy link
Contributor

With release 1.8.4 finished, we can merge this, thanks again @paulojmdias for the fix and for your patience!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 8ce3aae into hashicorp:main Oct 28, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.5
Development

Successfully merging this pull request may close these issues.

Add mkisofs command or equivalent into hashicorp:packer Docker image
4 participants
@paulojmdias @hashicorp-cla @lbajolet-hashicorp @nywilken