Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datasource: remove packer-image-iteration #12111

Merged
merged 1 commit into from
Nov 17, 2022
Merged

datasource: remove packer-image-iteration #12111

merged 1 commit into from
Nov 17, 2022

Conversation

lbajolet-hashicorp
Copy link
Contributor

The `packer-image-iteration' datasource is an undocumented, and unexported datasource, so it cannot be used by clients.

Since this is dead weight, we can remove it safely from the codebase.

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner November 14, 2022 22:11
nywilken
nywilken approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There is some documentation that needs to be removed as well https://github.com/hashicorp/packer/blob/main/website/content/docs/datasources/hcp/packer-image-iteration.mdx

I would just grok the code to ensure the are no references or comments to the datasource.

@nywilken nywilken added this to the 1.8.5 milestone Nov 16, 2022
@lbajolet-hashicorp
datasource: remove packer-image-iteration
5a38d17 
The `packer-image-iteration' datasource is an undocumented, and
unexported datasource, so it cannot be used by clients.

Since this is dead weight, we can remove it safely from the codebase.
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the rm_packer_image_iteration_ds branch from a8e9a4a to 5a38d17 Compare November 17, 2022 20:26
@lbajolet-hashicorp
Copy link
Contributor Author

Done, removed all the doc references to packer-image-iteration in the docs and code, both rg and find report nothing on them now

@lbajolet-hashicorp lbajolet-hashicorp merged commit 338c95b into main Nov 17, 2022
@lbajolet-hashicorp lbajolet-hashicorp deleted the rm_packer_image_iteration_ds branch November 17, 2022 20:47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.5
Development

Successfully merging this pull request may close these issues.
2 participants
@lbajolet-hashicorp @nywilken