Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of hcp: fix hcp artifact extraction method into release/1.10.x #12858

Conversation

hc-github-team-packer
Copy link
Collaborator

Backport

This PR is auto-generated from #12854 to be assessed for backporting due to the inclusion of the label backport/1.10.x.

The below text is copied from the body of the original PR.


With Packer 1.10.1 we started warning when a build failed to complete because of a potential incompatibility with the builder being used.

This led to cases in which the build failed for other reasons, and Packer would still warn of potential incompatibilities, even if the builder was in effect HCP compatible.

We attempted to fix this issue by introducing a new error type, and checks when we read the artifacts linked to a build, however this loop would fail when any one of the artifacts is not compatible with HCP Packer, leading to false failures.

To avoid this problem, we log incompatibilities to the verbose logger, and only signal the problem if all the artifacts could not be used to upload data to HCP Packer, in which case it's almost certain that if the build succeeded and no artifacts are registered to the build, that all the components used are not compatible with HCP, and should be reported as such to users.


Overview of commits

@hc-github-team-packer hc-github-team-packer requested a review from a team as a code owner February 27, 2024 16:39
@hc-github-team-packer hc-github-team-packer force-pushed the backport/fix_hcp_compat_detection/precisely-singular-grub branch 2 times, most recently from 9f352ba to 72485b7 Compare February 27, 2024 16:39
@hc-github-team-packer hc-github-team-packer merged commit fb4668d into release/1.10.x Feb 27, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the backport/fix_hcp_compat_detection/precisely-singular-grub branch February 27, 2024 16:39
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants