Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase 1: Packer Build Metadata #12866

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Phase 1: Packer Build Metadata #12866

merged 3 commits into from
Apr 11, 2024

Conversation

devashish-patel
Copy link
Contributor

@devashish-patel devashish-patel commented Mar 5, 2024 •
edited
Loading

Description

  • Track Packer Version and Plugins metadata and send it to HCP Packer

Tasks

  • Track packer version metadata
  • Track plugins name and version metadata
  • Send metadata to HCP Packer on each build update
  • Update hcp-sdk-go after the API release
  • HPATs passing on this branch

@devashish-patel devashish-patel self-assigned this Mar 5, 2024
@devashish-patel devashish-patel added core Core components of Packer hcp labels Mar 5, 2024
@devashish-patel devashish-patel marked this pull request as ready for review March 27, 2024 19:53
@devashish-patel devashish-patel requested a review from a team as a code owner March 27, 2024 19:53
@devashish-patel devashish-patel changed the title Phase 1: Packer Build Metadata (#12860) Phase 1: Packer Build Metadata Mar 27, 2024
lbajolet-hashicorp
lbajolet-hashicorp reviewed Apr 3, 2024
View reviewed changes
packer/plugin.go Show resolved Hide resolved
internal/hcp/registry/json.go Show resolved Hide resolved
packer/build.go Outdated Show resolved Hide resolved
@devashish-patel devashish-patel changed the base branch from main to release/1.10.x April 3, 2024 20:11
@devashish-patel devashish-patel changed the base branch from release/1.10.x to reset_1.10.x April 3, 2024 20:11
@devashish-patel devashish-patel changed the base branch from reset_1.10.x to main April 3, 2024 20:11
lbajolet-hashicorp
lbajolet-hashicorp reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the failing tests, LGTM!

@devashish-patel devashish-patel requested review from lbajolet-hashicorp and removed request for sylviamoss and JenGoldstrich April 4, 2024 15:39
@devashish-patel devashish-patel changed the base branch from main to release/1.10.x April 8, 2024 15:46
@devashish-patel devashish-patel changed the base branch from release/1.10.x to main April 8, 2024 15:53
@nywilken nywilken reopened this Apr 8, 2024
@devashish-patel
Use latest version of hcp-sdk-go
9ba3547 
Remove loggers and move AddMetadataToBuild method to Version
@devashish-patel devashish-patel force-pushed the build-metadata-phase-1 branch from 4962fb8 to 1b313ff Compare April 8, 2024 18:20
@devashish-patel devashish-patel changed the base branch from main to release/1.10.x April 8, 2024 18:22
@devashish-patel devashish-patel changed the base branch from release/1.10.x to main April 8, 2024 18:26
@devashish-patel devashish-patel force-pushed the build-metadata-phase-1 branch from 1b313ff to 9ba3547 Compare April 8, 2024 22:56
@devashish-patel devashish-patel removed the request for review from lbajolet-hashicorp April 11, 2024 14:50
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbajolet-hashicorp lbajolet-hashicorp merged commit edc8a4d into main Apr 11, 2024
11 checks passed
@devashish-patel devashish-patel deleted the build-metadata-phase-1 branch April 15, 2024 21:07
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JenGoldstrich JenGoldstrich JenGoldstrich left review comments

@sylviamoss sylviamoss sylviamoss left review comments

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

@nywilken nywilken Awaiting requested review from nywilken

Assignees

@devashish-patel devashish-patel

Labels
core Core components of Packer hcp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devashish-patel @sylviamoss @JenGoldstrich @lbajolet-hashicorp @nywilken