Allow manifest_file to be a directory for Puppet Masterless Porvisioner #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet is removing support for imports and node inherits. This change will support directories as manifests https://docs.puppetlabs.com/puppet/latest/reference/dirs_manifest.html https://docs.puppetlabs.com/puppet/latest/reference/lang_import.html
|
Hello can you consider this pull request, now that the build is passing. |
|
LGTM. Thanks! |
rasa
added a commit
that referenced
this pull request
Dec 30, 2014
Allow manifest_file to be a directory for Puppet Masterless Porvisioner
bhourigan
added a commit
to bhourigan/packer
that referenced
this pull request
Feb 19, 2015
… in the packer configuration. Issue hashicorp#1771 removed the type checking of manifest_file, but it never would puppet apply manifest_file as a directory, along with updated documentation.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet is removing support for imports and node inherits. This change will support directories as manifests
https://docs.puppetlabs.com/puppet/latest/reference/dirs_manifest.html
https://docs.puppetlabs.com/puppet/latest/reference/lang_import.html