Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallels Desktop 11: verify correct edition and enable headless mode #2662

Merged
merged 2 commits into from
Sep 16, 2015

Conversation

rickard-von-essen
Copy link
Collaborator

This improves the support for Parallels Desktop for Mac 11 support by:

  • Verify you are not trying to build with Standard Edition which lacks necessary command line support.
  • Enable headless mode for PD 11 (which was previously ignored).

Starting since Parallels Desktop 11, the command line functionality is
available only in Pro and Business editions.
@rickard-von-essen
Copy link
Collaborator Author

@legal90 could you review this, please.

@legal90
Copy link
Contributor

legal90 commented Aug 23, 2015

@rickard-von-essen Thanks!

It looks good to me, but I also think that "headless" mode can be enabled by default for PD 11.
And even more, it could be done just by adding []string{"set", vmName, "--startup-view", "headless"}
to SetDefaultConfiguration func for PD11 structure.
Then we don't need to check driver.SupportHeadless() and s.Headless.

Unlikely Virtualbox, headless mode in Parallels Desktop is more convenient, so user can always get a VM window by clicking VM name in the Parallels Desktop Control Center (VM list in GUI).

@rickard-von-essen
Copy link
Collaborator Author

@legal90 You are correct, I changed the code to always use headless on PD11 and to remove the headless config option for parallels builder. See 83980d2

@legal90
Copy link
Contributor

legal90 commented Aug 24, 2015

Great! LGTM

P.s. "Fixer" is a cool thing. We should use it to handle other deprecated options as well (like guest_os_distribution and parallels_tools_host_path)

rickard-von-essen added a commit that referenced this pull request Sep 16, 2015
Parallels Desktop 11: verify correct edition and enable headless mode
@rickard-von-essen rickard-von-essen merged commit b528811 into hashicorp:master Sep 16, 2015
@rickard-von-essen rickard-von-essen deleted the prl_pd11 branch September 18, 2015 07:32
@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants