Adding support for googlecompute startup scripts. #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @crunk1 - can you also update user-facing docs in https://github.com/mitchellh/packer/blob/master/website/source/docs/builders/googlecompute.html.md |
|
@erjohnso, done. |
|
Thanks @crunk1, this looks good to me. |
|
Ping? |
|
/cc @duftler in case this addition would be useful to you and you'd like a chance to review / comment. |
|
LGTM. Nice enhancement. We'll add support for this new capability to Spinnaker as well. |
|
Great. @cbednarski - please feel free to review / merge. |
- Startup scripts can be provided through the instance creation metadata field 'startup-script'. - Script log can be copied to a GCS location by setting the metadata field 'startup-script-log-dest'. Added Retry method to googlecompute package. Added GetSerialPortOutput to googlecompute Drivers. Added StepWaitInstanceStartup (and associated test) which waits for an instance startup-script to finish. Changed the instance service account to use the same service account as the one provided in the Packer config template. It was the project default service account. Tested googlecompute package with 'go test' and also performed builds with a startup script and without a startup script.
|
Thanks @erjohnso ! |
rickard-von-essen
added a commit
to rickard-von-essen/packer
that referenced
this pull request
Apr 2, 2017
Fixes issue with cross Project builds. Closes hashicorp#4608 Regression introduced in PR hashicorp#3639
rickard-von-essen
added a commit
to rickard-von-essen/packer
that referenced
this pull request
Apr 2, 2017
Fixes issue with cross Project builds. Closes hashicorp#4608 Regression introduced in PR hashicorp#3639
dayglojesus
pushed a commit
to dayglojesus/packer
that referenced
this pull request
Apr 6, 2017
Fixes issue with cross Project builds. Closes hashicorp#4608 Regression introduced in PR hashicorp#3639
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Retry method to googlecompute package. Used for polling with exponential backoff.
Added GetSerialPortOutput to googlecompute Drivers.
Added StepWaitInstanceStartup (and associated test) to googlecompute builder package which waits for an instance startup-script to finish.
Tested googlecompute package with 'go test' and also performed builds
with a startup script and without a startup script.