-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hard_drive_interface
option for VirtualBox builder
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterface` option (SATA only).
Perfect. I'm going to add a bit more validation but this looks good. |
mitchellh
added a commit
that referenced
this pull request
Sep 5, 2013
builder/virtualbox: Add `hard_drive_interface` option
mitchellh
added a commit
that referenced
this pull request
Apr 28, 2014
builder/virtualbox: Add `hard_drive_interface` option
annawake
pushed a commit
to boxcutter/centos
that referenced
this pull request
Feb 25, 2015
According to the virtualbox documentation: Like a real SATA controller, VirtualBox's virtual SATA controller operates faster and also consumes fewer CPU resources than the virtual IDE controller. Also, this allows you to connect up to 30 virtual hard disks to one machine instead of just three, as with the VirtualBox IDE controller (with the DVD drive already attached). This has been an option in Packer for a while now: hashicorp/packer#391 like so: "hard_drive_interface": "sata",
annawake
pushed a commit
to boxcutter/ubuntu
that referenced
this pull request
Feb 25, 2015
According to the virtualbox documentation: Like a real SATA controller, VirtualBox's virtual SATA controller operates faster and also consumes fewer CPU resources than the virtual IDE controller. Also, this allows you to connect up to 30 virtual hard disks to one machine instead of just three, as with the VirtualBox IDE controller (with the DVD drive already attached). This has been an option in Packer for a while now: hashicorp/packer#391 like so: "hard_drive_interface": "sata",
annawake
pushed a commit
to boxcutter/oraclelinux
that referenced
this pull request
Feb 25, 2015
According to the virtualbox documentation: Like a real SATA controller, VirtualBox's virtual SATA controller operates faster and also consumes fewer CPU resources than the virtual IDE controller. Also, this allows you to connect up to 30 virtual hard disks to one machine instead of just three, as with the VirtualBox IDE controller (with the DVD drive already attached). This has been an option in Packer for a while now: hashicorp/packer#391 like so: "hard_drive_interface": "sata",
byplayer
pushed a commit
to byplayer/ubuntu
that referenced
this pull request
Nov 1, 2017
According to the virtualbox documentation: Like a real SATA controller, VirtualBox's virtual SATA controller operates faster and also consumes fewer CPU resources than the virtual IDE controller. Also, this allows you to connect up to 30 virtual hard disks to one machine instead of just three, as with the VirtualBox IDE controller (with the DVD drive already attached). This has been an option in Packer for a while now: hashicorp/packer#391 like so: "hard_drive_interface": "sata",
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Packer attaches the primary hard disk to an IDE controller. However, this is sub-optimal as IDE hard disks do not support asynchronous I/O. This PR introduces a new option,
hard_drive_interface
, that allows customization of the disk controller. At this time, it only accepts"sata"
, but could be expanded for more elaborate configurations in the future (e.g., SCSI/SAS).