Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder/amazon: Allow using ssh_private_key_file and ssh_password #3953

Merged
merged 3 commits into from
Oct 3, 2016

Conversation

rickard-von-essen
Copy link
Collaborator

This adds support for using amazon-ebs/amazon-instance builder without
a keypair. If a ssh_private_key_file is supplied without a
ssh_keypair_name no temporary ssh keypair is created. If ssh_password
is used no temporary ssh keypair is created and the password is used when
trying to connect.

Closes #2301
Closes #3156

This adds support for using amazon-ebs/amazon-instance builder without
a keypair. If a ssh_private_key_file is supplied without a
ssh_keypair_name no temporary ssh keypair is created. If ssh_password is
used no temporary ssh keypair is created and the password is used when
trying to connect.

Closes hashicorp#2301
Closes hashicorp#3156
Copy link
Contributor

@mwhooker mwhooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@rickard-von-essen
Copy link
Collaborator Author

Maybe we need to clarify the docs a bit.

@mwhooker
Copy link
Contributor

mwhooker commented Oct 2, 2016

it's pretty complex logic, but it does seem intuitive. I agree, though, a more prosaic version of the RunConfig.Prepare comment in the docs would be useful.

@rickard-von-essen
Copy link
Collaborator Author

Updated the docs.

  1. Added info that keypairs will be skipped if ssh_password is set.
  2. Deleted ssh_username it's described in the Communicators section.

My creativeness is drained and I couldn't come up with a better RunConfig.Prepare comment.

@rickard-von-essen rickard-von-essen merged commit 0be3034 into hashicorp:master Oct 3, 2016
@rickard-von-essen rickard-von-essen deleted the amz-ssh branch October 3, 2016 08:22
@mwhooker
Copy link
Contributor

mwhooker commented Oct 3, 2016

😄

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants