Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder/triton: Reconcile #4829 and #4838 docs #4839

Merged
merged 2 commits into from
Apr 26, 2017
Merged

builder/triton: Reconcile #4829 and #4838 docs #4839

merged 2 commits into from
Apr 26, 2017

Conversation

jen20
Copy link
Collaborator

@jen20 jen20 commented Apr 26, 2017

Fixes #4829.

@mwhooker
Copy link
Contributor

Here's the reasoning for changing the default DC:

The threw me off a bit was that in triton/access_config.go#L30, it defaults to us-east-1 as default datacenter even though this is not documented and all Joyent docs use us-sw-1 as default datacenter.

I really think we should change the default to be what users expect (and clearly document it).

mwhooker
mwhooker suggested changes Apr 26, 2017
View reviewed changes
website/source/docs/builders/triton.html.md Outdated
"source_machine_package": "g3-standard-0.5-smartos",
"source_machine_image": "70e3ae72-96b6-11e6-9056-9737fd4d0764",
"source_machine_package": "g4-highcpu-128M",
"source_machine_image": "f6acf198-2037-11e7-8863-8fdd4ce58b6a",

"ssh_username": "root",
"ssh_private_key_file": "~/.ssh/id_rsa",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be changed unless ~ expansion works now

@jen20
builder/triton: Reconcile #4829 and #4838 docs
d2ae362 
This changes the default region to match the default from Joyent
documentation.
@jen20
Copy link
Collaborator Author

jen20 commented Apr 26, 2017

@mwhooker good call - that line actually isn't necessary at all since we by default use the SSH agent for authentication if it is being used for signing requests and nothing else is specified.

@mwhooker
Copy link
Contributor

ok seems good. there's a line about key material that needs to be update but I'll take care of it

@mwhooker mwhooker merged commit 919ade4 into hashicorp:master Apr 26, 2017
@rickard-von-essen
Copy link
Collaborator

Great! 👍

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwhooker mwhooker mwhooker requested changes

@rickard-von-essen rickard-von-essen Awaiting requested review from rickard-von-essen

Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jen20 @mwhooker @rickard-von-essen