builder/amazon: set flag to delete temporary keypair #4850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4807
The logic was getting far too complicated to decide if we need to clean up a temporary key pair, so let's just set a flag after we do create one.
Also noticed that openstack replicated the same complicated logic, so I added the flag there, too.
I feel like this is too simple a fix for what appears to be complex logic, so I'd like a second set of eyes on this if possible.