Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker metadata fields that can be changed #4867

Merged
merged 3 commits into from
May 10, 2017
Merged

Update docker metadata fields that can be changed #4867

merged 3 commits into from
May 10, 2017

Conversation

szkl
Copy link
Contributor

@szkl szkl commented May 9, 2017 •
edited
Loading

  • Deprecation notice for MAINTAINER field.
  • Adds LABEL and ONBUILD fields.
Error response from daemon: maintainer is not a valid change command

I've looked up what fields are accepted by docker commit --change in the reference when I got this error.

rickard-von-essen
rickard-von-essen requested changes May 10, 2017
View reviewed changes
Copy link
Collaborator

@rickard-von-essen rickard-von-essen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been removed in Docker 1.12.

Instead of removing them write a note about that it is deprecated and has been removed in 1.12.

szkl added 3 commits May 10, 2017 17:03
@szkl
Add deprecation notice for MAINTAINER field
1d66ecf 
Signed-off-by: Sönmez Kartal <szkl89@gmail.com>
@szkl
Add LABEL field to acceptable metadata list
56ec046 
Signed-off-by: Sönmez Kartal <szkl89@gmail.com>
@szkl
Add ONBUILD field to acceptable metadata list
b189252 
Signed-off-by: Sönmez Kartal <szkl89@gmail.com>
@szkl
Copy link
Contributor Author

szkl commented May 10, 2017

Updated.

@mwhooker mwhooker added the docs label May 10, 2017
@mwhooker mwhooker added this to the v1.0.1 milestone May 10, 2017
@mwhooker
Copy link
Contributor

Will wait for rickard to sign off on changes and merge

rickard-von-essen
rickard-von-essen approved these changes May 10, 2017
View reviewed changes
Copy link
Collaborator

@rickard-von-essen rickard-von-essen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwhooker mwhooker merged commit fca5c1e into hashicorp:master May 10, 2017
@szkl szkl deleted the website-builder-docker-changes branch May 11, 2017 21:37
@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickard-von-essen rickard-von-essen rickard-von-essen approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@szkl @mwhooker @rickard-von-essen