Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention network config for HTTPIP template variable #6159

Closed
wants to merge 1 commit into from

Conversation

milch
Copy link

@milch milch commented Apr 18, 2018

See for example #4091 (comment)

I lost a couple hours troubleshooting this, before I found the above issue comment, so I think it's definitely a good thing to mention in the docs.

@milch milch requested a review from a team as a code owner April 18, 2018 21:33
@mwhooker
Copy link
Contributor

thanks for the note. definitely good to add. This will break after #6129 is merged, so might wait until after that before merging this one

@mwhooker mwhooker added this to the v1.2.3 milestone Apr 18, 2018
@mwhooker mwhooker self-assigned this Apr 18, 2018
@milch
Copy link
Author

milch commented Apr 18, 2018

Sure, sounds good to me!

@mwhooker
Copy link
Contributor

done in 40d054a

@mwhooker mwhooker closed this Apr 20, 2018
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants