Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the delay between Hyper-V VM startup and hyper-v builder's ability to send keystrokes to the target VM. #7970

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

williamb1024
Copy link
Contributor

The Hyper-V ISO builder attempts to determine the host's IP address after starting the target VM, waiting for the boot_wait value to expire, and before sending boot_command keystrokes. Because the amount of time to determine the host's IP address can vary the actual wait time before sending boot_command keystrokes is indeterminate.

This commit moves the HostIp determination before the target VM is started, so that the boot_command keystrokes wait can be controlled in a more accurate manner.

This commit also modifies the steps to connect to the VM (in non-headless mode) before the VM is started in an attempt to further ensure the boot wait timeout is not unintentionally extended.

May close: #7278

@williamb1024
Copy link
Contributor Author

Verified with Windows Server 2016 installation that these changes do allow the boot command to generate key presses quickly enough that the "Press any key to boot from CD prompt" can be acknowledged. #7278

@SwampDragons
Copy link
Contributor

Needed to rebase on master in order to get the make-generate-check passing.

@SwampDragons SwampDragons merged commit b6fdccc into hashicorp:master Aug 19, 2019
@SwampDragons SwampDragons added this to the 1.4.4 milestone Sep 3, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generation 2 Hyper-V VM boots too fast for boot_command to trigger
2 participants