Override post-processor config on the fly #8592
Conversation
sylviamoss
changed the title
| @@ -246,6 +229,17 @@ func (p *PostProcessor) configureSingle(c *Config, raws ...interface{}) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *PostProcessor) specificConfig(name string) (Config, error) { | |||
There was a problem hiding this comment.
this is in a new method to allow me to test it
There was a problem hiding this comment.
Super nice one; this LGTM.
Looking a bit in the past, I see that configs map[string]*Config was introduced in 5e2f08d for overrides; but it's the only place it was done like this and I think overriding will work the same with this change.
We still have to think about overriding in HCL2; I think the features of HCL2 will allow to not have to do this.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
To keep the PostPorcessor struct consistent with the others, the configuration override logic was moved from Configure to PostProcess. This way, the Config struct will remain the same all the time and it will be overwritten on the fly whenever it is necessary.
Closes #8585