Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation new version of 2019-06-01 #1340

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

wuxu92
Copy link
Collaborator

@wuxu92 wuxu92 commented Aug 19, 2022

@wuxu92 wuxu92 changed the title Add automation new version of 2019-06-01 Add automation new version of 2019-06-01 Aug 19, 2022
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wuxu92
One question below, can you detail why we need this older API?

Thanks!

@@ -25,7 +25,7 @@ service "attestation" {
}
service "automation" {
name = "Automation"
available = ["2021-06-22"]
available = ["2019-06-01", "2021-06-22"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is older than anything currently in use by the provider. What are we getting from this older version of the API?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, we currently use the 2020-01-13-preview of Azure/azure-sdk-for-go mainly and part of the resources use 2021-06-22 of Hashcorp/go-azure-sdk.

Version 2021-06-22 only contains 4 of 27 swaggers that exist in version 2019-06-01 so we need the old version's API.

and there are some updates that only exist in the 2019-06-01 version(e.g Azure/azure-rest-api-specs#19367 which is needed for the issue hashicorp/terraform-provider-azurerm#1602). and by git log, the version 2019-06-01 stable version should be newer than 2020-01-13-preview.

@tombuildsstuff tombuildsstuff merged commit c3e62cd into hashicorp:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants