importer: use RawFile instead of object for request as object type but format with file
#2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
suggested changes
Apr 6, 2023
There was a problem hiding this comment.
hey @wuxu92
Thanks for this PR - I've taken a look through and left some comments inline, if we can fix those up then this should otherwise be good to go 👍
Thanks!
tools/importer-rest-api-specs/components/parser/testdata/model_single_with_rawfile.json
Outdated
Show resolved
Hide resolved
tombuildsstuff
suggested changes
Apr 6, 2023
There was a problem hiding this comment.
hey @wuxu92
Thanks for pushing those changes, I've taken a look through and left another couple of minor comments inline, but it appears that some of the comments from last time were missed?
Thanks!
|
thanks for your comments, sorry i did not get all your points in the last push 🔆 |
tombuildsstuff
approved these changes
May 3, 2023
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to resolve: #2185
imported cs file: