-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/importer-rest-api-specs: adding a workaround for HDInsight 26838 #3404
Merged
tombuildsstuff
merged 2 commits into
main
from
f/swagger-workaround-for-hdinsight-cluster-kind
Nov 24, 2023
Merged
tools/importer-rest-api-specs: adding a workaround for HDInsight 26838 #3404
tombuildsstuff
merged 2 commits into
main
from
f/swagger-workaround-for-hdinsight-cluster-kind
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
added
the
area/data-canonicalisation
Issues around Data Normalisation/Canonicalisation
label
Nov 24, 2023
tombuildsstuff
force-pushed
the
f/swagger-workaround-for-hdinsight-cluster-kind
branch
from
November 24, 2023 11:33
c97fec7
to
7b5c701
Compare
catriona-m
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tools/importer-rest-api-specs/components/parser/dataworkarounds/workaround_hdinsight_26838.go
Outdated
Show resolved
Hide resolved
…s/workaround_hdinsight_26838.go Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com>
tombuildsstuff
deleted the
f/swagger-workaround-for-hdinsight-cluster-kind
branch
November 24, 2023 15:31
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Nov 30, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Dec 14, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Dec 14, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Dec 14, 2023
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Jan 25, 2024
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
tombuildsstuff
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Jan 26, 2024
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Jan 30, 2024
… lower-cased due to an issue in the API Spec The API Specification defines `tier` as a Constant which can be recased - however the `kind` is defined as a string, thus can't be. I've opened hashicorp/pandora#3404 (to workaround it) and Azure/azure-rest-api-specs#26838 (to fix it) - once those are threaded through both of these should be normalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around Azure/azure-rest-api-specs#26838