Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: add BotService@2021-05-01-preview #3511

Closed
wants to merge 4 commits into from

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Dec 18, 2023

Hi @tombuildsstuff , I submitted PR to switch to go-azure-sdk for BotService to fix the issue as you suggested. But seems CI in this PR is failed. Could you take a look? Thanks.

@neil-yechenwei neil-yechenwei changed the title Config: add Bot@2021-05-01-preview Config: add BotService@2021-05-01-preview Dec 18, 2023
@tombuildsstuff
Copy link
Contributor

Dependent on #3576

@tombuildsstuff tombuildsstuff removed their assignment Jan 8, 2024
@tombuildsstuff
Copy link
Contributor

hey @neil-yechenwei

Taking a look through here I'm not entirely sure what's going on with the Github Actions - but in pulling this down locally it appears there's an inconsistency in the upstream API Definition, which I've opened Azure/azure-rest-api-specs#27351 to fix.

As a part of getting that fixed I've opened #3609 which both adds a Data Workaround to fix that issue, but also imports the latest Stable API Version for Bot Service (2022-09-15) which should unblock this one - and then #3611 will update the integer constants to use the display name.

However since #3609 and #3611 are going to resolve this and import a stable version of this API - I hope you don't mind but I'm going to close this in favour of #3609, once both are merged this should become available however.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants