Fail starting a tcp_transport with no ip (#403)

hashicorp · Jun 29, 2020 · ae3f4f2 · ae3f4f2
1 parent 5927dcd
commit ae3f4f2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/tcp_transport.go b/tcp_transport.go
@@ -81,7 +81,7 @@ func newTCPTransport(bindAddr string,
 		list.Close()
 		return nil, errNotTCP
 	}
-	if addr.IP.IsUnspecified() {
+	if addr.IP == nil || addr.IP.IsUnspecified() {
 		list.Close()
 		return nil, errNotAdvertisable
 	}

diff --git a/tcp_transport_test.go b/tcp_transport_test.go
@@ -12,6 +12,13 @@ func TestTCPTransport_BadAddr(t *testing.T) {
 	}
 }
 
+func TestTCPTransport_EmptyAddr(t *testing.T) {
+	_, err := NewTCPTransportWithLogger(":0", nil, 1, 0, newTestLogger(t))
+	if err != errNotAdvertisable {
+		t.Fatalf("err: %v", err)
+	}
+}
+
 func TestTCPTransport_WithAdvertise(t *testing.T) {
 	addr := &net.TCPAddr{IP: []byte{127, 0, 0, 1}, Port: 12345}
 	trans, err := NewTCPTransportWithLogger("0.0.0.0:0", addr, 1, 0, newTestLogger(t))