Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure 'make deps' downloads test dependencies like testify #309

Merged
merged 1 commit into from
Feb 26, 2019
Merged

ensure 'make deps' downloads test dependencies like testify #309

merged 1 commit into from
Feb 26, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Feb 25, 2019

No description provided.

@rboyer
Copy link
Member Author

rboyer commented Feb 25, 2019

@i0rek I think PR #308 is hitting this, and I noticed in your leadership transfer branch that you mitigated this a little bit differently.

@rboyer rboyer requested a review from a team February 25, 2019 22:25
hanshasselberg
hanshasselberg approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@rboyer rboyer merged commit d9475b5 into master Feb 26, 2019
@rboyer rboyer deleted the fix-make-deps branch February 26, 2019 15:22
@rboyer rboyer mentioned this pull request Feb 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rboyer @hanshasselberg