Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ForceLeave Prune #580

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Update ForceLeave Prune #580

merged 4 commits into from
Oct 2, 2019

Conversation

schristoff
Copy link
Contributor

ForceLeave previously didn't take into consideration what occurs during StatusLeaving and StatusAlive. The handlePrune() function was created to allow for different statuses to prune nodes.

@schristoff schristoff requested a review from a team September 24, 2019 20:12
serf/serf.go Show resolved Hide resolved
serf/serf.go Outdated Show resolved Hide resolved
@rboyer
Copy link
Member

rboyer commented Sep 24, 2019

I think this probably warrants a test or two.

@schristoff schristoff requested a review from rboyer October 1, 2019 17:42
serf/serf.go Outdated Show resolved Hide resolved
serf/serf_test.go Outdated Show resolved Hide resolved
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@schristoff schristoff merged commit 1d3fdf9 into master Oct 2, 2019
@schristoff schristoff deleted the handlePrune branch October 2, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants