Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @actions/core from 1.9.1 to 1.10.0 #247

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Bump @actions/core from 1.9.1 to 1.10.0 #247

merged 2 commits into from
Nov 1, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 3, 2022 •
edited
Loading

Bumps @actions/core from 1.9.1 to 1.10.0.

Changelog

Sourced from @​actions/core's changelog.

1.10.0

  • saveState and setOutput now use environment files if available #1178
  • getMultilineInput now correctly trims whitespace by default #1185
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner October 3, 2022 18:00
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 3, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/actions/core-1.10.0 branch from 61ca0d5 to 15e4f09 Compare October 4, 2022 08:06
@dependabot
Bump @actions/core from 1.9.1 to 1.10.0
72674f1 
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

---
updated-dependencies:
- dependency-name: "@actions/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/actions/core-1.10.0 branch from 15e4f09 to 72674f1 Compare October 4, 2022 08:07
jpogran
jpogran requested changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require investigation because setouput is now deprecated https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@magnetikonline magnetikonline mentioned this pull request Oct 12, 2022
Closed
@evanrappe
Copy link

Any updates on this one? Would clean up a ton of noise for all TF commands leveraging this action.

@sivapalan
Copy link

sivapalan commented Oct 19, 2022 •
edited
Loading

@jpogran Looks like this should only require bumping version in wrapper/ and updating dist/index.js.

The setOutput function has been updated to use the file-command if supported. Otherwise, it will fall back to use the pre-existing workflow command set-output. See actions/toolkit#1178

@hadim
Copy link

hadim commented Oct 25, 2022

Commenting to get updates on ETA here. We are also seeing a large amount of warnings on our side.

@sivapalan sivapalan mentioned this pull request Oct 26, 2022
Closed
@bryantbiggs
Copy link

bryantbiggs commented Oct 29, 2022 •
edited
Loading

This will require investigation because setouput is now deprecated github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands

@jpogran the setOutput function is still available in the @actions/core, all that is required is ensuring you upgrade to at least v1.10.0 of the library and the warnings will go away

Action authors who are using the toolkit should update the @actions/core package to v1.10.0 or greater to get the updated saveState and setOutput functions.

jpogran
jpogran approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bryantbiggs bryantbiggs mentioned this pull request Oct 31, 2022
Merged
6 tasks
@bendbennett bendbennett merged commit 633666f into main Nov 1, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/actions/core-1.10.0 branch November 1, 2022 16:16
@bflad bflad mentioned this pull request Feb 14, 2023
Merged
@austinvalle austinvalle mentioned this pull request Oct 9, 2023
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivapalan sivapalan sivapalan approved these changes

@jpogran jpogran jpogran approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evanrappe @sivapalan @hadim @bryantbiggs @jpogran @bendbennett