Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses tool cache - skips wrapper create on hit. #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jcuffe
Copy link

@jcuffe jcuffe commented Mar 6, 2021

I noticed that this library was using the actions/tool-cache, which has great helpers for saving and loading from the runner cache.

I wanted this for my own project in order to save resources on my free Github plan. I recently learned that actions/cache works well with actions/tool-cache, even on Github runners, so this could be useful to others as well!

The existing API is maintained. The only logic change necessary aside from checking the cache, was to skip creation of the wrapper when loading from cache (to prevent the terraform-bin terraform executable from being replaced with the cached wrapper script living in terraform).

Let me know if any further changes are necessary to integrate!

@jpogran jpogran added the enhancement New feature or request label Mar 7, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@jpogran
Copy link
Collaborator

jpogran commented May 18, 2022

Thank you for the contribution @jcuffe! Apologies on the delay in reviewing your PR. I appreciate that you've added tests for this use case as well. I'll be reviewing this PR this week.

@shahariaazam
Copy link

@jpogran any time to review this.

@shahariaazam
Copy link

@jpogran Any time to review this yet?

@oradwell
Copy link

this action still doesn't support tool cache. any chance in reviewing this @austinvalle ? happy to create a new PR if the author is no longer available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants