Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme #11
Update Readme #11
Changes from 1 commit
c18259a
b7b30c0
64f8935
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what are the other cases here, in which end-users would want to use the grammars directly? Maybe it wasn't clear what I meant by "end-user" above - should I clarify that to "Editor end-user"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be resolved by splitting up this document as discussed in https://github.com/hashicorp/syntax/pull/11/files#r821403019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great deep dive into how this all works, but it is a lot of info to drop in a README we don't expect to have external help just yet, which will probably change a lot in the next few cycles. I think this probably is better suited in the development.md or in a CONTRIBUTING.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could cut it down a bit and move some content into separate files but there are different types of content which we should not conflate and probably not put into CONTRIBUTING nor DEVELOPMENT.
From my POV there are different personas we're targeting here (1) end-users of editors/websites, (2) maintainers of extensions/websites (3) contributors to our grammars
USAGE.md
- as from their POV they're using ithcl.tmGrammar.json
orterraform.tmGrammar.json
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not tied to filenames, but from your response we appear to be in agreement that this README should be a landing page and not a catalogue of all the different sets of knowledge required to use the files in this repo.
Extrapolating from your thoughts, I think we need:
Since the goal of this PR is to get the project quickly to the point of unblocking other work, I'm fine with ticketing this as a follow up and merging this PR as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 created #14 to track the remaining work