Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentinel syntax highlighting #141

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

glennsarti
Copy link
Contributor

@glennsarti glennsarti commented Aug 15, 2024

This PR updates the Sentinel Syntax Highlighting:

  • Moves to an easier to understand "repository" style location for types of matches. This is similar to the TF syntax
  • Updates the inbuilt function matching to NOT highlight non-function call locations e.g.
append(foo, bar)    <-- Highlight "append"
append = 2          <-- Do not highlight as it's not a function call
  • Adds missing builtin function compare
  • Fixes highlighting double symbol operators e.g. ==
  • Highlights triple and double word operators better e.g. is not empty

Note this PR should be squash merged

@glennsarti glennsarti requested a review from a team as a code owner August 15, 2024 07:40
@glennsarti
Copy link
Contributor Author

This is not everything, but it's a big enough chunk for a single PR.

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jpogran jpogran merged commit c2419c1 into hashicorp:main Aug 15, 2024
5 checks passed
@glennsarti glennsarti deleted the gs/sentinel-fix-case branch August 16, 2024 01:21
@jpogran jpogran added the enhancement New feature or request label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants