Fix ingress security group rule #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
approved these changes
Jul 24, 2023
Ganeshrockz
added a commit
that referenced
this pull request
Jul 31, 2023
* Update main.tf * Fix fmt
2 tasks
Ganeshrockz
added a commit
that referenced
this pull request
Aug 1, 2023
* Fix acceptance tests (#186) * Fix acceptance tests * Revert 1.16 consul version * Skip running tests * Add egress rule * Fix egress * Fix fmt * Fix fmt * Remove egress * Fix egress rules * Fix tests * Fix * Add egress rules * Fix * Enable more tests * Add ingress rules * Bring back HCP tests * Remove ingress * Add back ingress * Enable only HCP * Enable all tests * Fix ingress security group rule (#187) * Update main.tf * Fix fmt * Bump consul and envoy versions (#185) * Bump consul and envoy versions * Address comments * Fix consul versions * Address comments * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
CI
How I expect reviewers to test this PR:
Checklist: