Changes to adopt Consul Dataplane architecture for Consul ECS #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests Modify mesh-task and controller
* Run HCP tests * TriggerPR * Run only HCP tests * Enable HCP * merge branches * Fix HCP tests * Minor changes * Remove audit log tests * Fix workflow yaml * Remove provider * Merge changes * Terraform fmt * Fix tests
* Modified mesh gateways to support dataplane * Fix fmt
…corp/terraform-aws-consul-ecs into ganeshrockz/dataplane-arch-changes
Ganeshrockz
requested review from
a team,
sarahethompson,
dlaguerta,
kisunji and
cthain
and removed request for
a team
Ganeshrockz
commented
Aug 24, 2023
cthain
reviewed
Aug 30, 2023
cthain
approved these changes
Aug 30, 2023
* Service sameness example config * Added Changelog * Export mesh gateways * Address comments
…corp/terraform-aws-consul-ecs into ganeshrockz/dataplane-arch-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
CI, Manual deployment
How I expect reviewers to test this PR:
Most of these files were already reviewed as part of previous PRs. I would like some 👀 on the CHANGELOG because that is the only major addition to the feature branch after all the other changes.
Checklist: