-
Notifications
You must be signed in to change notification settings - Fork 466
Replace backtick in run-vault with single quote #120
Replace backtick in run-vault with single quote #120
Conversation
* Backticks causing unexpected behavior * Removes backticks in favor of single quote to match other items in the list * Credit to @BonzTM in hashicorp#77 for initially finding/fixing; isolated to get fix merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, good catch! I wonder how this hadn't caused issues before?
I'll merge now and let the tests run. If they pass, I'll issue a new release. Thanks!
@brikis98 any visibility into why the tests are failing? Locally it seems related to the enterprise vault being embedded into the tests. |
Build info is here: https://circleci.com/gh/hashicorp/terraform-aws-vault/215 @Etiene Any idea what this test failure is all about? Specific log file is at https://215-103201301-gh.circle-artifacts.com/0/tmp/logs/TestMainVaultCluster.log. Relevant part seems to be:
|
The change introduced in #117 added the endpoint attribute to the config; but this is only available in Vault OSS 1.0.0 and Enterprise. Perhaps the config entry for endpoint wasn't supported in enterprise? Based on hashicorp/vault@3d1f0d7 it seems endpoint may be a new feature. |
@briandbecker That might be the case! @Etiene worked on that stuff and will take a look once she frees up. |
@briandbecker you are correct! thanks for catching this. I'm adding a fix in PR #122 |
list
fix merged