Skip to content
This repository was archived by the owner on Jan 25, 2023. It is now read-only.

Edit default value for availability_zones and subnet_ids vars to null #206

Conversation

rafaelremondes
Copy link

Related to Issue 181 in terraform-aws-consul.

Newest provider-aws version only allows us to set one of the 2 variables: availability_zones and subnet_ids when creating AutoScalingGroups.

As per @brikis98 suggestion, I am changing the default value of these 2 variables to null so they're no longer conflicting, allowing to set either of them when using the vault_cluster module.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 1, 2020

CLA assistant check
All committers have signed the CLA.

@brikis98
Copy link
Collaborator

brikis98 commented Aug 6, 2020

Thanks for the PR! We need to resolve #196 first and can then take a look at this PR. Hoping to get to that in the next week or two. If anyone has cycles to look into it before then, help is very appreciated!

@brikis98
Copy link
Collaborator

Thanks for the PR! This was already done as part of the fixes in #195.

@brikis98 brikis98 closed this Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants