This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Add test for Vault Enterprise install #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etiene
force-pushed
the
test/enterprise-install
branch
from
5f16334 to
9822e24
Compare
Etiene
changed the title
|
Please review #87 before this one and I will rebase appropriately |
brikis98
approved these changes
Aug 29, 2018
|
|
||
| func TestVaultClusterEnterpriseWithAmazonLinuxAmi(t *testing.T) { | ||
| t.Parallel() | ||
| runVaultEnterpriseClusterTest(t, "amazon-linux-ami", "ec2-user", os.Getenv("VAULT_AMI_TEMPLATE_VAR_DOWNLOAD_URL")) |
There was a problem hiding this comment.
The use of an env var here won't be obvious to future maintainers. Consider add a method that:
- Explicitly checks if the env var is set
- Reports an error that says "Env var xxx not found. Please set it to a Vault Enterprise download URL to run this test."
- Add a comment to the method explaining that Vault Enterprise URLs should be kept secret, so we use an env var to avoid putting it directly in our code or logs.
test/vault_helpers.go
Outdated
| // 3. Deploy that AMI using the example Terraform code | ||
| // 4. SSH to a Vault node and initialize the Vault cluster | ||
| // 5. SSH to each Vault node and unseal it | ||
| // 5. SSH to a Vault node and make sure you can communicate with the nodes via Consul-managed DNS |
There was a problem hiding this comment.
5 is repeated twice (if you copy/pasted this comment block, might be a bug in the original!). Also, add another step here: check enterprise version of Vault got installed correctly.
Etiene
force-pushed
the
test/enterprise-install
branch
from
5a29519 to
28212b8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@infosecgithub