feat(lib): throw error when a token is used in a construct name

Closes #1068

packages/cdktf/lib/terraform-element.ts

@@ -1,4 +1,5 @@
 import { Construct } from "constructs";
+import { Tokenization } from ".";
 import { TerraformStack } from "./terraform-stack";
 
 export interface TerraformElementMetadata {
@@ -19,6 +20,12 @@ export class TerraformElement extends Construct {
   constructor(scope: Construct, id: string) {
     super(scope, id);
 
+    if (Tokenization.containsToken(id)) {
+      throw new Error(
+        "You can not use a Token (e.g. a reference to an attribute) as name of a construct"
+      );
+    }
+
     this.node.addMetadata("stacktrace", "trace");
     this.cdktfStack = TerraformStack.of(this);
   }

packages/cdktf/lib/tokens/token.ts

@@ -115,6 +115,10 @@ export class Tokenization {
     return [];
   }
 
+  public static containsToken(x: any): boolean {
+    return Tokenization.reverse(x).length > 0;
+  }
+
   /**
    * Un-encode a string potentially containing encoded tokens
    */

packages/cdktf/test/resource.test.ts

@@ -160,3 +160,21 @@ test("numeric attributes", () => {
 
   expect(Testing.synth(stack)).toMatchSnapshot();
 });
+
+test("tokens as ids", () => {
+  const app = Testing.app();
+  const stack = new TerraformStack(app, "test");
+  new TestProvider(stack, "provider", {});
+
+  const foo = new TestResource(stack, "resource", {
+    name: "foo",
+  });
+
+  expect(() => {
+    new TestResource(stack, `resource-${foo.stringValue}`, {
+      name: "foo",
+    });
+  }).toThrowErrorMatchingInlineSnapshot(
+    `"You can not use a Token (e.g. a reference to an attribute) as name of a construct"`
+  );
+});