Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: how to include providers with dashes? #1250

Closed
figadore opened this issue Nov 4, 2021 · 2 comments · Fixed by #1252
Closed

golang: how to include providers with dashes? #1250

figadore opened this issue Nov 4, 2021 · 2 comments · Fixed by #1252
Assignees
Labels
bug Something isn't working confirmed independently reproduced by an engineer on the team language/golang provider get / generation

Comments

@figadore
Copy link

figadore commented Nov 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

cdktf: 0.6.4

Affected Resource(s)

google-beta.*

Debug Output

generated/hashicorp/google-beta/google-beta.go:2:15: syntax error: unexpected -, expecting semicolon or newline
cdktf encountered an error while synthesizing

Expected Behavior

google-beta should be converted to google_beta or googlebeta? or a way to alias providers should exist?

Actual Behavior

google-beta.go starts with

package google-beta

which is invalid go

Steps to Reproduce

Run cdktf init --template="go" --local

Add the following to cdktf.json

  "terraformProviders": [
    "hashicorp/google@~> 3.90",
    "hashicorp/google-beta@~> 3.90",
  ],

Run cdktf get

Run cdktf synth

@figadore figadore added bug Something isn't working new Un-triaged issue labels Nov 4, 2021
@figadore figadore changed the title golang: how to include providers with dashes golang: how to include providers with dashes? Nov 4, 2021
@ansgarm ansgarm self-assigned this Nov 4, 2021
@ansgarm ansgarm added confirmed independently reproduced by an engineer on the team language/golang provider get / generation and removed new Un-triaged issue labels Nov 4, 2021
ansgarm added a commit that referenced this issue Nov 4, 2021
@ansgarm
Copy link
Member

ansgarm commented Nov 4, 2021

Hi @figadore! Thank you for reporting the bug 👍 I created a PR and with the next release of cdktf-cli this will work.
Until we release a new version cdktf-cli@next should work (as soon as the build finishes after merging the PR).

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working confirmed independently reproduced by an engineer on the team language/golang provider get / generation
Projects
None yet
2 participants