Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure two providers with same name but from different namespaces can be used at the same time #1258

Closed
ansgarm opened this issue Nov 5, 2021 · 1 comment · Fixed by #3442
Closed

Ensure two providers with same name but from different namespaces can be used at the same time #1258

ansgarm opened this issue Nov 5, 2021 · 1 comment · Fixed by #3442
Assignees
@ansgarm
Labels
core-parity Better experience in Terraform Core than CDKTF enhancement New feature or request needs-reproduction needs-research priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. provider get / generation

Comments

@ansgarm
Copy link
Member

ansgarm commented Nov 5, 2021 •
edited
Loading

I'm not sure where the cdktf.json schema is documented, but I tried a few variations of the block syntax

   "terraformProviders": [
    {
       "name": "google-beta",
       "source": "google-beta",
       "version": "4.0.0"
     }
   ],

and nothing helped with collisions. I hoped that something similar to terraform's alias field would work, since collisions need to be handled somehow (e.g. how do I use both Runelab/bitbucket and aeirola/bitbucket?), but maybe this is a separate issue.

Originally posted by @figadore in #1252 (comment)
@ansgarm ansgarm added core-parity Better experience in Terraform Core than CDKTF needs-priority Issue has not yet been prioritized; this will prompt team review needs-research provider get / generation labels Nov 5, 2021
@ansgarm ansgarm mentioned this issue Nov 5, 2021
Merged
@ansgarm ansgarm added needs-priority Issue has not yet been prioritized; this will prompt team review and removed needs-priority Issue has not yet been prioritized; this will prompt team review labels Nov 5, 2021
@DanielMSchmidt DanielMSchmidt added priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. and removed needs-priority Issue has not yet been prioritized; this will prompt team review labels Nov 30, 2021
@xiehan xiehan added the enhancement New feature or request label Mar 10, 2023
@ansgarm ansgarm mentioned this issue Jan 19, 2024
Merged
1 task
ansgarm added a commit that referenced this issue Jan 19, 2024
@ansgarm
feat(provider-generator): support renaming provider names in order to…
7840fd6 
… allow using two providers sharing the same name at the same time (#3442)

Adds support for the Terraform feature described here:
https://developer.hashicorp.com/terraform/language/providers/requirements#handling-local-name-conflicts

Resolves #1258

### Open items
- [x] add test case for JSON and HCL output when using two providers
with the same name
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ansgarm ansgarm

Labels
core-parity Better experience in Terraform Core than CDKTF enhancement New feature or request needs-reproduction needs-research priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. provider get / generation
Projects
None yet
Milestone
No milestone
3 participants
@xiehan @ansgarm @DanielMSchmidt