Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge provider test constructs version mismatch #1410

Closed
jsteinich opened this issue Dec 12, 2021 · 4 comments · Fixed by #1460
Closed

Edge provider test constructs version mismatch #1410

jsteinich opened this issue Dec 12, 2021 · 4 comments · Fixed by #1460
Labels
bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/medium estimated < 1 week testing

Comments

@jsteinich
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

Any version with c#

Affected Resource(s)

c# edge provider test

Debug Output

Version conflict detected for Constructs. Install/reference Constructs 10.0.12 directly to project MyTerraformStack to resolve this issue.

Expected Behavior

Test passes

Actual Behavior

Test fails because the null and edge providers have different construct versions

Steps to Reproduce

Build edge provider with one constructs version and null provider with a different one

References

cdklabs/jsii-srcmak#271

Ideally cdklabs/jsii-srcmak#271 would be fixed since then the version would need to match exactly.
We could probably directly reference a version of constructs either in the test or always in the c# template. This will still generate warnings, but shouldn't be an error.

@jsteinich jsteinich added bug Something isn't working new Un-triaged issue labels Dec 12, 2021
@DanielMSchmidt
Copy link
Contributor

This should be slved by #1414

@jsteinich
Copy link
Collaborator Author

This should be slved by #1414

That fixes this for now, but it will break again the next time a new constructs version is released.

@ansgarm ansgarm added priority/important-soon High priority, to be worked on as part of our current release or the following one. size/medium estimated < 1 week testing and removed new Un-triaged issue labels Dec 17, 2021
@DanielMSchmidt
Copy link
Contributor

#1444 is fixing this again 🙈

@ansgarm ansgarm added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon High priority, to be worked on as part of our current release or the following one. labels Jan 5, 2022
DanielMSchmidt added a commit that referenced this issue Jan 6, 2022
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/medium estimated < 1 week testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants