Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wafv2WebAcl: Extraneous JSON object property "managedRuleGroupStatement" #3458

Closed
1 task
xxjt123xx opened this issue Jan 23, 2024 · 2 comments
Closed
1 task
Labels
bug Something isn't working

Comments

@xxjt123xx
Copy link

xxjt123xx commented Jan 23, 2024

Expected Behavior

This was working a few weeks ago and now is giving a build error with no code changes.
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/wafv2_web_acl?lang=typescript#managedRuleGroupStatement

Actual Behavior

Build should be working

Steps to Reproduce

  1. Add Wafv2WebAcl
  2. Add a rule with managedRuleGroupStatement

Versions

language = typescript
cdktf = ^0.20.1
cdktf-cli = ^0.20.1
@cdktf/provider-aws = 19.2.0

Providers

AWS

Gist

No response

Possible Solutions

No response

Workarounds

No response

Anything Else?

No response

References

No response

Help Wanted

  • I'm interested in contributing a fix myself

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@xxjt123xx xxjt123xx added bug Something isn't working new Un-triaged issue labels Jan 23, 2024
@ansgarm
Copy link
Member

ansgarm commented Jan 23, 2024

Hi @xxjt123xx 👋

There has been a small performance related change to that resource in CDKTF 0.20.1 (changelog, PR) which removes generated types for some attributes of this resource.

To fix the error you are encountering, change the casing of all keys in the rule > statement block to snake case. It should then look like this:

statement: {
managed_rule_group_statement: {
name: "managed-rule-example",
vendor_name: "AWS",
excluded_rule: [
{
name: "SizeRestrictions_QUERYSTRING",
},
{ name: "SQLInjection_QUERYSTRING" },
],
scope_down_statement: {
geo_match_statement: {
country_codes: ["US"],
},
},
},
},

Sorry for the trouble this change caused! We'd have liked to solve it in another way but there sadly was no sensible alternative.

@ansgarm ansgarm removed the new Un-triaged issue label Jan 23, 2024
@xiehan xiehan changed the title COMPONENT: Wafv2WebAcl - Extraneous JSON object property "managedRuleGroupStatement" Wafv2WebAcl: Extraneous JSON object property "managedRuleGroupStatement" Jan 23, 2024
@xiehan xiehan closed this as completed Jan 23, 2024
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants