Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): Skip statement block for rule block in aws_wafv2_web_acl and aws_wafv2_rule_group resources #3414

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Jan 11, 2024

This is a breaking change for users of these properties in these resources. It is necessary to bring down the size of the generated Go code though and also has an effect on all other languages.

For Go it shrinks the size of the generated code for the AWS provider from 648MB to 357MB. Previously the two resources accounted for 187MB (web acl) and 103MB (rule group) of the total size

Our resource docs already state that some attributes are skipped which includes mentions of the web acl resources (even though they weren't affected in the past)

Resolves #3358

…afv2_web_acl and aws_wafv2_rule_group resources

This is a breaking change for users of these properties in these resources. It is necessary to bring down the size of the generated Go code though and also has an effect on all other languages.

For Go it shrinks the size of the generated code for the AWS provider from 648MB to 357MB. Previously the two resources accounted for 187MB (web acl) and 103MB (rule group) of the total size

Our resource docs already state that some attributes are skipped which includes mentions of the web acl resources (even though they weren't affected in the past)
@ansgarm ansgarm requested a review from a team as a code owner January 11, 2024 14:11
@ansgarm ansgarm requested review from DanielMSchmidt and Maed223 and removed request for a team January 11, 2024 14:11
@ansgarm ansgarm changed the title fix(provider-generator): Skip statement block for rule block in aws_wafv2_web_acl and aws_wafv2_rule_group resources fix(provider-generator): Skip statement block for rule block in aws_wafv2_web_acl and aws_wafv2_rule_group resources Jan 11, 2024
@ansgarm ansgarm merged commit 56a63c2 into main Jan 12, 2024
427 checks passed
@ansgarm ansgarm deleted the skip-statement-wafv2 branch January 12, 2024 12:40
ansgarm added a commit that referenced this pull request Jan 16, 2024
## 0.20.1

**AWS Provider changes (breaking)**

The AWS pre-built provider for Go is currently too large to be installed
due to a hard limit in Go. This release adds skipping the `statement`
block in the `rule` block of the `aws_wafv2_web_acl` and
`aws_wafv2_rule_group` resources. Our [resource docs
page](https://developer.hashicorp.com/terraform/cdktf/concepts/resources#special-cases)
previously already mentioned that these resources have skipped
attributes but they weren't actually skipped. This almost doubled AWS
provider bindings in size due to the recursive nature of the `statement`
block.
If you are using any of these two resources, the `statement` now has to
be passed as a plain object instead and its keys have to be snake-cased
(e.g. `and_statement` or `regex_match_statement`).

### feat

- feat(hcl2cdk): support import blocks in cdktf convert
[\#3415](#3415)

### fix

- fix(provider-generator): Skip `statement` block for `rule` block in
`aws_wafv2_web_acl` and `aws_wafv2_rule_group` resources
[\#3414](#3414)
- fix(cli): Fix version range matching for 0.x version ranges with the
~> operator
[\#3403](#3403)
- fix(docs): fix complex iterator example
[\#3410](#3410)
- fix(docs): product relative links
[\#3401](#3401)

### chore

- chore: Upgrade dependencies for @cdktf/provider-generator
[\#3423](#3423)
- chore: break loop properly
[\#3413](#3413)
- chore: abort rebase when retrying pushing doc updates
[\#3412](#3412)
- chore: update registry docs tool
[\#3407](#3407)
- chore: update registry docs tool
[\#3406](#3406)
- chore: update provider docs tool
[\#3404](#3404)
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider add: unable to add aws provider due to tree too large
2 participants