-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(provider-generator): Skip statement
block for rule
block in aws_wafv2_web_acl
and aws_wafv2_rule_group
resources
#3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afv2_web_acl and aws_wafv2_rule_group resources This is a breaking change for users of these properties in these resources. It is necessary to bring down the size of the generated Go code though and also has an effect on all other languages. For Go it shrinks the size of the generated code for the AWS provider from 648MB to 357MB. Previously the two resources accounted for 187MB (web acl) and 103MB (rule group) of the total size Our resource docs already state that some attributes are skipped which includes mentions of the web acl resources (even though they weren't affected in the past)
ansgarm
requested review from
DanielMSchmidt and
Maed223
and removed request for
a team
January 11, 2024 14:11
ansgarm
changed the title
fix(provider-generator): Skip statement block for rule block in aws_wafv2_web_acl and aws_wafv2_rule_group resources
fix(provider-generator): Skip Jan 11, 2024
statement
block for rule
block in aws_wafv2_web_acl
and aws_wafv2_rule_group
resources
DanielMSchmidt
approved these changes
Jan 11, 2024
… test As we now skip the large wafv2 resources there is no more sharding happening for exactly this resource
…to skipped attribute
ansgarm
added a commit
that referenced
this pull request
Jan 16, 2024
## 0.20.1 **AWS Provider changes (breaking)** The AWS pre-built provider for Go is currently too large to be installed due to a hard limit in Go. This release adds skipping the `statement` block in the `rule` block of the `aws_wafv2_web_acl` and `aws_wafv2_rule_group` resources. Our [resource docs page](https://developer.hashicorp.com/terraform/cdktf/concepts/resources#special-cases) previously already mentioned that these resources have skipped attributes but they weren't actually skipped. This almost doubled AWS provider bindings in size due to the recursive nature of the `statement` block. If you are using any of these two resources, the `statement` now has to be passed as a plain object instead and its keys have to be snake-cased (e.g. `and_statement` or `regex_match_statement`). ### feat - feat(hcl2cdk): support import blocks in cdktf convert [\#3415](#3415) ### fix - fix(provider-generator): Skip `statement` block for `rule` block in `aws_wafv2_web_acl` and `aws_wafv2_rule_group` resources [\#3414](#3414) - fix(cli): Fix version range matching for 0.x version ranges with the ~> operator [\#3403](#3403) - fix(docs): fix complex iterator example [\#3410](#3410) - fix(docs): product relative links [\#3401](#3401) ### chore - chore: Upgrade dependencies for @cdktf/provider-generator [\#3423](#3423) - chore: break loop properly [\#3413](#3413) - chore: abort rebase when retrying pushing doc updates [\#3412](#3412) - chore: update registry docs tool [\#3407](#3407) - chore: update registry docs tool [\#3406](#3406) - chore: update provider docs tool [\#3404](#3404)
1 task
1 task
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for users of these properties in these resources. It is necessary to bring down the size of the generated Go code though and also has an effect on all other languages.
For Go it shrinks the size of the generated code for the AWS provider from 648MB to 357MB. Previously the two resources accounted for 187MB (web acl) and 103MB (rule group) of the total size
Our resource docs already state that some attributes are skipped which includes mentions of the web acl resources (even though they weren't affected in the past)
Resolves #3358