Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for building modules #718

Closed
jsteinich opened this issue May 25, 2021 · 1 comment · Fixed by #848
Closed

Update documentation for building modules #718

jsteinich opened this issue May 25, 2021 · 1 comment · Fixed by #848
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request modules priority/important-soon High priority, to be worked on as part of our current release or the following one.
Milestone

Comments

@jsteinich
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When we expanded module support beyond the Terraform registry (and for submodules), the documentation wasn't really updated to account for that. Both https://github.com/hashicorp/terraform-cdk/blob/main/docs/working-with-cdk-for-terraform/using-providers-and-modules.md and https://github.com/hashicorp/terraform-cdk/blob/main/docs/working-with-cdk-for-terraform/cdktf-json.md don't really explain the new functionality.

References

#584
#563

@jsteinich jsteinich added enhancement New feature or request new Un-triaged issue documentation Improvements or additions to documentation labels May 25, 2021
@skorfmann skorfmann added this to the v0.5 milestone May 25, 2021
@danieldreier danieldreier modified the milestones: v0.4.x, 0.5 Jun 25, 2021
@danieldreier danieldreier added modules priority/important-soon High priority, to be worked on as part of our current release or the following one. and removed new Un-triaged issue labels Jul 2, 2021
DanielMSchmidt added a commit that referenced this issue Jul 27, 2021
DanielMSchmidt added a commit that referenced this issue Jul 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request modules priority/important-soon High priority, to be worked on as part of our current release or the following one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants