Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicated jest interface members #1042

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

hasantayyar
Copy link
Contributor

This duplication is harmless so this change is more like a linting.

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 17, 2021

CLA assistant check
All committers have signed the CLA.

@ansgarm
Copy link
Member

ansgarm commented Sep 17, 2021

Thanks @hasantayyar!
Just had a look at it and I think it is supposed to be toHaveDataSourceWithProperties instead. So it's probably a copy & paste error.
Or have I overlooked something?
Greetings to Berlin!

@hasantayyar
Copy link
Contributor Author

Thanks @hasantayyar!
Just had a look at it and I think it is supposed to be toHaveDataSourceWithProperties instead. So it's probably a copy & paste error.
Or have I overlooked something?

Yes it's probably a copy paste mistake but I didn't take the risk for fixing that :) instead just removed the duplication to avoid confusion

@ansgarm
Copy link
Member

ansgarm commented Sep 17, 2021

Understandably!
I just added the missing definition and rebased your branch 👍

@ansgarm ansgarm merged commit fc849b5 into hashicorp:main Sep 17, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
@hasantayyar hasantayyar deleted the patch-1 branch December 29, 2022 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants