Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(hcl2cdk): re-enable test case for convert #1118

Closed
wants to merge 0 commits into from

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Oct 4, 2021

No description provided.

@ansgarm ansgarm requested a review from DanielMSchmidt October 4, 2021 14:20
@ansgarm ansgarm changed the title tests(hcl2cdk): re-enable test case for convert test(hcl2cdk): re-enable test case for convert Oct 4, 2021
@ansgarm ansgarm force-pushed the re-enable-convert-test branch from 27a6cc1 to 8f007ce Compare October 4, 2021 14:21
@DanielMSchmidt DanielMSchmidt force-pushed the re-enable-convert-test branch 2 times, most recently from 456f742 to 9f27f65 Compare October 4, 2021 17:42
@jsteinich
Copy link
Collaborator

This looks very similar to what I was working on with #938. I hope to have that updated shortly.

@jsteinich
Copy link
Collaborator

I ended up creating #1120 since the refactorings made updating #938 more trouble than it was worth.

@DanielMSchmidt DanielMSchmidt force-pushed the re-enable-convert-test branch from 9f27f65 to a5a0cf8 Compare October 5, 2021 08:30
@DanielMSchmidt DanielMSchmidt deleted the re-enable-convert-test branch October 5, 2021 08:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants