feat(lib): Add support for for expressions
#1130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
changed the title
for expressions
adds an TFExpression to express a Terraform expression like `[for i in var.list: i+1]`
ansgarm
force-pushed
the
add-for-expression
branch
from
7c2b3cd to
953892d
Compare
ansgarm
changed the title
for expressionsfor expressions
|
It does need more than just tests as it won't be supported in jsii as is so it may make sense to wait on it, but it could definitely be useful. |
Closed
|
|
|
Closing for now |
ansgarm
added a commit
that referenced
this pull request
Jul 11, 2022
Code copied and adjusted from my former (and later closed) PR #1130
ansgarm
added a commit
that referenced
this pull request
Jul 19, 2022
Code copied and adjusted from my former (and later closed) PR #1130
ansgarm
added a commit
that referenced
this pull request
Jul 19, 2022
Code copied and adjusted from my former (and later closed) PR #1130
ansgarm
added a commit
that referenced
this pull request
Jul 20, 2022
Code copied and adjusted from my former (and later closed) PR #1130
ansgarm
added a commit
that referenced
this pull request
Jul 21, 2022
Code copied and adjusted from my former (and later closed) PR #1130
ansgarm
added a commit
that referenced
this pull request
Jul 22, 2022
Code copied and adjusted from my former (and later closed) PR #1130
DanielMSchmidt
pushed a commit
that referenced
this pull request
Jul 28, 2022
Code copied and adjusted from my former (and later closed) PR #1130
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an TFExpression to express a Terraform expression like
[for i in var.list: i+1]I built this while working on support for
Fn::Cidrfor #1123. Turns out I did not need it 😅So I moved it into this draft PR and thought I'd let you vote:
👍 - write tests for it and get it merged
👎 - ditch it, close this PR and hope someone remembers it, when might we need support for it
P.S. The interesting part starts in line 123 👇