Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): document numeric tokens #1140

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Oct 13, 2021

I'm trying to add number tokens here so folks who see these have a place to look them up

@DanielMSchmidt DanielMSchmidt changed the title docs(lib): document numeric tokens chore(docs): document numeric tokens Oct 13, 2021
@DanielMSchmidt DanielMSchmidt force-pushed the DanielMSchmidt-numeric-tokens branch from 88cb6f7 to d44a9b7 Compare October 13, 2021 15:42
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One tiny nitpick suggestion and then you can merge!

website/docs/cdktf/concepts/tokens.html.md Outdated Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the DanielMSchmidt-numeric-tokens branch from 38ab1c8 to 2c594b9 Compare October 15, 2021 08:56
@DanielMSchmidt DanielMSchmidt merged commit cae0403 into terraform-io-docs Oct 15, 2021
@DanielMSchmidt DanielMSchmidt deleted the DanielMSchmidt-numeric-tokens branch October 15, 2021 08:58
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants