Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Add constructs documentation to website #1338

Merged
merged 8 commits into from
Nov 23, 2021
Merged

chore(docs): Add constructs documentation to website #1338

merged 8 commits into from
Nov 23, 2021

Conversation

laurapacilio
Copy link
Contributor

@laurapacilio laurapacilio commented Nov 22, 2021 •
edited
Loading

This PR:

  • Adds constructs documentation to the concepts section of the Terraform website.
  • Adds the constructs page to the relevant place in the sidebar
  • Adds a linked reference on the architecture.html, providers-and-resources.html, and stacks.html pages

@laurapacilio laurapacilio changed the title (chore)docs: Add constructs documentation to website chore(docs): Add constructs documentation to website Nov 22, 2021
@laurapacilio
Copy link
Contributor Author

@ansgarm once you and the team feel comfortable with this, would you mind merging? I just don't have permissions :-)

@ansgarm
Copy link
Member

ansgarm commented Nov 23, 2021

@laurapacilio I wanted to give @schersh a chance to read first, but we already talked about it and she'll merge it then :)

laurapacilio and others added 2 commits November 23, 2021 13:37
@laurapacilio @schersh
Update website/docs/cdktf/concepts/constructs.html.md
451a8ca 
Co-authored-by: Sarah MacDonald <schersh@users.noreply.github.com>
@laurapacilio @schersh
Update website/docs/cdktf/concepts/constructs.html.md
343e13d 
Co-authored-by: Sarah MacDonald <schersh@users.noreply.github.com>
schersh
schersh approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approving with a few link fixes.

laurapacilio and others added 2 commits November 23, 2021 13:39
@schersh schersh merged commit f586fc0 into main Nov 23, 2021
@schersh schersh deleted the add-constructs-docs branch November 23, 2021 18:41
@skorfmann skorfmann mentioned this pull request Nov 26, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schersh schersh schersh approved these changes

@ansgarm ansgarm ansgarm approved these changes

@DanielMSchmidt DanielMSchmidt Awaiting requested review from DanielMSchmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurapacilio @ansgarm @schersh