fix(lib): Add struct sharding for providers without namespaces #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
approved these changes
Dec 2, 2021
packages/@cdktf/provider-generator/lib/get/__tests__/provider.test.ts
Outdated
Show resolved
Hide resolved
packages/@cdktf/provider-generator/lib/get/generator/models/resource-model.ts
Outdated
Show resolved
Hide resolved
ansgarm
reviewed
Dec 2, 2021
packages/@cdktf/provider-generator/lib/get/generator/provider-generator.ts
Outdated
Show resolved
Hide resolved
packages/@cdktf/provider-generator/lib/get/generator/provider-generator.ts
Outdated
Show resolved
Hide resolved
skorfmann
changed the title
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dashboard resource has too man exports and runs into microsoft/TypeScript#38691
In contrast to what got fixed in #1248 for the AWS provider, the Datadog provider doesn't have namespaces. Hence, this PR adds struct sharding for providers without namespaces.
Fixes #1374